Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): switch to native navigator #2072

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jul 17, 2024

Description

Switch all StackNavigators to NativeStackNavigator and fix Home screen/Profile/Scanner gestures.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-07-17.at.15.21.07.mp4

Copy link

socket-security bot commented Jul 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/helper-create-class-features-plugin@7.24.1 None 0 430 kB nicolo-ribaudo
npm/@babel/helper-create-regexp-features-plugin@7.22.1 None +1 80.8 kB nicolo-ribaudo
npm/@babel/helper-hoist-variables@7.22.5 None 0 7.03 kB nicolo-ribaudo
npm/@babel/helper-member-expression-to-functions@7.23.0 None 0 55 kB nicolo-ribaudo
npm/@babel/helper-optimise-call-expression@7.22.5 None 0 6.66 kB nicolo-ribaudo
npm/@babel/helper-replace-supers@7.24.1 None 0 32.2 kB nicolo-ribaudo
npm/@babel/helper-skip-transparent-expression-wrappers@7.22.5 None 0 5.96 kB nicolo-ribaudo
npm/@babel/helper-string-parser@7.24.1 None 0 31.7 kB nicolo-ribaudo
npm/@babel/plugin-proposal-class-properties@7.18.6 None 0 3.34 kB nicolo-ribaudo
npm/@babel/plugin-proposal-nullish-coalescing-operator@7.18.6 None 0 4.41 kB nicolo-ribaudo
npm/@babel/plugin-proposal-optional-chaining@7.21.0 None 0 33.2 kB nicolo-ribaudo
npm/@babel/plugin-syntax-export-default-from@7.18.6 None 0 2.79 kB nicolo-ribaudo
npm/@babel/plugin-syntax-flow@7.21.4 None 0 5.42 kB nicolo-ribaudo
npm/@babel/plugin-syntax-jsx@7.21.4 None 0 4.13 kB nicolo-ribaudo
npm/@babel/plugin-syntax-typescript@7.21.4 None 0 6.86 kB nicolo-ribaudo
npm/@babel/plugin-transform-flow-strip-types@7.21.0 None 0 17.5 kB nicolo-ribaudo
npm/@babel/plugin-transform-modules-commonjs@7.24.1 None 0 42.4 kB nicolo-ribaudo
npm/@babel/plugin-transform-named-capturing-groups-regex@7.22.5 None +1 58.7 kB nicolo-ribaudo
npm/@babel/plugin-transform-nullish-coalescing-operator@7.24.1 None 0 9.15 kB nicolo-ribaudo
npm/@babel/plugin-transform-optional-chaining@7.24.1 None 0 38 kB nicolo-ribaudo
npm/@babel/plugin-transform-parameters@7.24.1 None 0 64.9 kB nicolo-ribaudo
npm/@babel/plugin-transform-private-methods@7.24.1 None 0 4.69 kB nicolo-ribaudo
npm/@babel/plugin-transform-private-property-in-object@7.24.1 None +1 22.9 kB nicolo-ribaudo
npm/@babel/plugin-transform-shorthand-properties@7.24.1 None 0 7.11 kB nicolo-ribaudo
npm/@babel/plugin-transform-spread@7.24.1 None 0 21.2 kB nicolo-ribaudo
npm/@babel/plugin-transform-sticky-regex@7.24.1 None 0 4.64 kB nicolo-ribaudo
npm/@babel/plugin-transform-template-literals@7.24.1 None 0 15.9 kB nicolo-ribaudo
npm/@babel/plugin-transform-typescript@7.22.3 None 0 126 kB nicolo-ribaudo
npm/@babel/plugin-transform-unicode-regex@7.24.1 None +1 57.7 kB nicolo-ribaudo
npm/@jest/schemas@29.6.3 None 0 6.07 kB simenb
npm/@jest/types@29.6.3 None +5 146 kB simenb
npm/@noble/hashes@1.3.1 None 0 743 kB paulmillr
npm/@react-navigation/native-stack@6.10.1 Transitive: environment +2 474 kB satya164
npm/@react-navigation/native@6.1.18 environment +5 1.4 MB satya164
npm/@types/node@20.3.2 None 0 3.79 MB types
npm/ajv@8.12.0 eval 0 1.02 MB esp
npm/babel-plugin-polyfill-corejs2@0.4.10 Transitive: unsafe +2 297 kB nicolo-ribaudo
npm/core-js-compat@3.33.2 None 0 686 kB zloirock
npm/cross-fetch@3.1.8 network 0 75.1 kB lquixada
npm/cross-spawn@7.0.3 environment, filesystem, shell 0 21.2 kB satazor
npm/eslint-scope@5.1.1 None 0 78.4 kB eslintbot
npm/fast-xml-parser@4.3.4 None 0 112 kB amitgupta
npm/flow-parser@0.206.0 None 0 768 kB flowtype
npm/glob@7.2.3 filesystem +1 58.7 kB isaacs
npm/is-wsl@2.2.0 environment, filesystem 0 3.76 kB sindresorhus
npm/jest-environment-node@29.7.0 unsafe 0 9.37 kB simenb
npm/loose-envify@1.4.0 environment 0 5.81 kB zertosh
npm/metro-config@0.80.7 filesystem Transitive: environment, eval, network, unsafe +9 515 kB metro-bot
npm/metro-core@0.80.7 None 0 20.9 kB metro-bot
npm/metro-runtime@0.80.7 None 0 73.3 kB metro-bot
npm/metro-source-map@0.80.7 None +2 120 kB metro-bot
npm/metro@0.80.7 environment, filesystem, network +10 2.97 MB metro-bot
npm/onetime@5.1.2 None 0 6.17 kB sindresorhus
npm/pretty-format@26.6.2 None 0 67.6 kB simenb
npm/prompts@2.4.2 None 0 187 kB terkelg
npm/resolve@1.22.2 environment, filesystem +2 158 kB ljharb
npm/serve-static@1.15.0 None +2 43.4 kB dougwilson
npm/strip-ansi@5.2.0 None 0 4.17 kB sindresorhus
npm/tslib@2.5.0 None 0 60 kB typescript-bot
npm/yargs@17.7.2 environment, filesystem 0 292 kB oss-bot

🚮 Removed packages: npm/@istanbuljs/schema@0.1.3, npm/@nodelib/fs.stat@2.0.5, npm/@react-navigation/native-stack@6.9.26, npm/@react-navigation/native@6.1.17, npm/@react-navigation/stack@6.3.29, npm/@types/scheduler@0.16.3, npm/agent-base@7.1.1, npm/async@3.2.4, npm/available-typed-arrays@1.0.5, npm/bn.js@4.12.0, npm/buffer@5.7.1, npm/camelcase@5.3.1, npm/diff-sequences@29.6.3, npm/entities@4.5.0, npm/env-paths@2.2.1, npm/esprima@4.0.1, npm/estraverse@5.3.0, npm/fsevents@2.3.2, npm/get-caller-file@2.0.5, npm/has-bigints@1.0.2, npm/ip@2.0.0, npm/is-callable@1.2.7, npm/is-glob@4.0.3, npm/istanbul-lib-coverage@3.2.0, npm/merge2@1.4.1, npm/minimalistic-assert@1.0.1, npm/nan@2.17.0, npm/neo-async@2.6.2, npm/picomatch@2.3.1, npm/queue-microtask@1.2.3, npm/source-map@0.7.4, npm/yargs-parser@21.1.1

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/protobufjs@7.2.4
  • Install script: postinstall
  • Source: node scripts/postinstall
🚫
Install scripts npm/protobufjs@6.11.3
  • Install script: postinstall
  • Source: node scripts/postinstall
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/protobufjs@7.2.4
  • @SocketSecurity ignore npm/protobufjs@6.11.3

@pwltr pwltr requested a review from limpbrains July 18, 2024 07:24
Copy link
Collaborator

@limpbrains limpbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much smoother now

@limpbrains limpbrains merged commit 2856e4f into master Jul 18, 2024
6 of 7 checks passed
@limpbrains limpbrains deleted the fix/native-navigation branch July 18, 2024 09:49
@pwltr pwltr self-assigned this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants