fix: prevent wallet from beeing initalized twice #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwltr
requested changes
Sep 6, 2024
limpbrains
force-pushed
the
rbf-strikes-back
branch
from
381b851
to
f65e0b9
Compare
limpbrains
force-pushed
the
rbf-strikes-back
branch
from
f65e0b9
to
ae1cb8e
Compare
pwltr
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After new wallet creation
setupOnChainWalletwas called twice resulting in 2 instances of Beignet competing against each other.I'm fixing it by
walletExists: truesetter to be executed later, after thecreateDefaultWalletfunction is completedLinked Issues/Tasks
closes #2177
Type of change
Bug fix
Tests
No test
QA Notes