Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use StrongBox on Android #2231

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: don't use StrongBox on Android #2231

merged 1 commit into from
Sep 12, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Sep 12, 2024

Description

Adds a patch to remove usage of StrongBox secure element on Android.

Although StrongBox is a little slower and resource constrained (meaning that it supports fewer concurrent operations) compared to TEE, StrongBox provides better security guarantees against physical and side-channel attacks. If you want to prioritize higher security guarantees over app resource efficiency, we recommend using StrongBox on the devices where it is available. Wherever StrongBox isn't available, your app can always fall back to TEE to store key materials.

See https://synonymworkspace.slack.com/archives/C01H106JRQB/p1725562106199429

Linked Issues/Tasks

Closes #2014

Copy link

socket-security bot commented Sep 12, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/protobufjs@7.2.4 ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/protobufjs@7.2.4

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks good to me) 👏

@pwltr pwltr self-assigned this Sep 12, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/eslint-parser@7.22.15 unsafe 0 135 kB nicolo-ribaudo
npm/@eslint-community/regexpp@4.10.1 None 0 432 kB eslint-community-bot
npm/@nicolo-ribaudo/eslint-scope-5-internals@5.1.1-v1 None 0 1.66 kB nicolo-ribaudo
npm/@protobufjs/aspromise@1.1.2 None 0 9.05 kB dcode
npm/@protobufjs/base64@1.1.2 None 0 9.22 kB dcode
npm/@protobufjs/codegen@2.0.4 None 0 9.14 kB dcode
npm/@protobufjs/eventemitter@1.1.0 None 0 7.75 kB dcode
npm/@protobufjs/fetch@1.1.0 network 0 8.76 kB dcode
npm/@protobufjs/float@1.0.2 None 0 27 kB dcode
npm/@protobufjs/inquire@1.1.0 None 0 4.29 kB dcode
npm/@protobufjs/path@1.1.2 None 0 7.77 kB dcode
npm/@protobufjs/pool@1.1.0 None 0 6.25 kB dcode
npm/@protobufjs/utf8@1.1.0 None 0 23.5 kB dcode
npm/@react-native/eslint-config@0.75.2 None 0 18.3 kB react-native-bot
npm/@react-native/eslint-plugin@0.75.2 None 0 6.5 kB react-native-bot
npm/@types/json-schema@7.0.14 None 0 31.7 kB types
npm/@types/long@4.0.2 None 0 13.3 kB types
npm/@types/semver@7.5.4 None 0 23.2 kB types
npm/@typescript-eslint/eslint-plugin@7.12.0 None 0 2.73 MB jameshenry
npm/@typescript-eslint/parser@7.12.0 None 0 18 kB jameshenry
npm/@typescript-eslint/scope-manager@7.12.0 None 0 613 kB jameshenry
npm/@typescript-eslint/type-utils@7.12.0 None 0 110 kB jameshenry
npm/@typescript-eslint/types@7.12.0 None 0 156 kB jameshenry
npm/@typescript-eslint/typescript-estree@7.12.0 None 0 577 kB jameshenry
npm/@typescript-eslint/utils@7.12.0 None 0 332 kB jameshenry
npm/@typescript-eslint/visitor-keys@7.12.0 None 0 19.4 kB jameshenry
npm/array-buffer-byte-length@1.0.0 None 0 8.05 kB ljharb
npm/array-includes@3.1.7 None 0 25.4 kB ljharb
npm/array.prototype.tosorted@1.1.2 None 0 18.8 kB ljharb
npm/asynciterator.prototype@1.0.0 None 0 7.23 kB ljharb
npm/define-properties@1.2.0 None 0 12.5 kB ljharb
npm/doctrine@2.1.0 None 0 106 kB eslint
npm/es-abstract@1.22.3 None 0 2.02 MB ljharb
npm/es-iterator-helpers@1.0.15 None 0 155 kB ljharb
npm/es-set-tostringtag@2.0.2 None 0 9.49 kB ljharb
npm/eslint-config-prettier@8.10.0 None 0 19.9 kB lydell
npm/eslint-plugin-eslint-comments@3.2.0 None 0 41.8 kB mysticatea
npm/eslint-plugin-ft-flow@3.0.11 None 0 512 kB brianzchen
npm/eslint-plugin-jest@27.9.0 filesystem 0 325 kB simenb
npm/eslint-plugin-react-hooks@4.6.0 environment 0 118 kB gnoff
npm/eslint-plugin-react-native-globals@0.1.2 None 0 1.87 kB satya164
npm/eslint-plugin-react-native@4.1.0 None 0 52.7 kB tomhastjarjanto
npm/eslint-plugin-react@7.33.2 filesystem 0 795 kB ljharb
npm/eslint-scope@5.1.1 None 0 78.4 kB eslintbot
npm/eslint-visitor-keys@2.1.0 None 0 24.7 kB eslintbot
npm/globalthis@1.0.3 None 0 22.4 kB ljharb
npm/google-protobuf@3.21.2 None 0 820 kB dibenede
npm/has-property-descriptors@1.0.0 None 0 9.31 kB ljharb
npm/hasown@2.0.0 None 0 10.8 kB ljharb
npm/ignore@5.2.4 None 0 51.2 kB kael
npm/internal-slot@1.0.6 None 0 20.1 kB ljharb
npm/is-array-buffer@3.0.2 None 0 11.9 kB ljharb
npm/is-shared-array-buffer@1.0.2 None 0 11.9 kB ljharb
npm/long@4.0.0 None 0 177 kB dcode
npm/object.assign@4.1.4 None 0 1.17 MB ljharb
npm/object.entries@1.1.7 None 0 31.4 kB ljharb
npm/object.fromentries@2.0.7 None 0 15.6 kB ljharb
npm/object.hasown@1.1.3 None 0 16.1 kB ljharb
npm/object.values@1.1.7 None 0 30.9 kB ljharb
npm/protobufjs@7.2.4 filesystem, network 0 2.74 MB google-wombot
npm/regexp.prototype.flags@1.5.1 None 0 39 kB ljharb
npm/set-function-name@2.0.1 None 0 10.1 kB ljharb
npm/string-natural-compare@3.0.1 None 0 10.1 kB nwoltman
npm/string.prototype.matchall@4.0.10 None 0 36.6 kB ljharb

🚮 Removed packages: npm/@eslint/eslintrc@2.1.4, npm/@eslint/js@8.57.0, npm/@humanwhocodes/config-array@0.11.14, npm/@humanwhocodes/module-importer@1.0.1, npm/@humanwhocodes/object-schema@2.0.3, npm/@trysound/sax@0.2.0, npm/@types/uuid@9.0.8, npm/@ungap/structured-clone@1.2.0, npm/acorn-jsx@5.3.2, npm/ansi-escapes@4.3.2, npm/array-flatten@1.1.1, npm/async@3.2.5, npm/bluebird@3.7.2, npm/body-parser@1.20.2, npm/content-disposition@0.5.4, npm/content-type@1.0.5, npm/cookie-signature@1.0.6, npm/cookie@0.6.0, npm/csso@5.0.5, npm/csstype@3.1.2, npm/deep-is@0.1.4, npm/dot-case@3.0.4, npm/eslint@8.57.0, npm/espree@9.6.1, npm/express@4.19.2, npm/fast-json-stable-stringify@2.1.0, npm/fast-levenshtein@2.0.6, npm/file-entry-cache@6.0.1, npm/flat-cache@3.2.0, npm/flatted@3.3.1, npm/forwarded@0.2.0, npm/functions-have-names@1.2.3, npm/has-bigints@1.0.2, npm/ipaddr.js@1.9.1, npm/is-async-function@2.0.0, npm/is-bigint@1.0.4, npm/is-boolean-object@1.1.2, npm/is-date-object@1.0.5, npm/is-finalizationregistry@1.0.2, npm/is-number-object@1.0.7, npm/is-path-inside@3.0.3, npm/is-symbol@1.0.4, npm/isarray@2.0.5, npm/json-buffer@3.0.1, npm/json-stable-stringify-without-jsonify@1.0.1, npm/keyv@4.5.4, npm/levn@0.4.1, npm/lower-case@2.0.2, npm/media-typer@0.3.0, npm/merge-descriptors@1.0.1, npm/methods@1.1.2, npm/no-case@3.0.4, npm/path-to-regexp@0.1.7, npm/path-type@4.0.0, npm/prelude-ls@1.2.1, npm/proxy-addr@2.0.7, npm/raw-body@2.5.2, npm/snake-case@3.0.4, npm/strip-json-comments@3.1.1, npm/text-table@0.2.0, npm/type-check@0.4.0, npm/type-is@1.6.18, npm/which-boxed-primitive@1.0.2, npm/which-builtin-type@1.1.3

View full report↗︎

@pwltr pwltr merged commit c460244 into master Sep 12, 2024
7 checks passed
@pwltr pwltr deleted the chore/patches branch September 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android startup time is slow
2 participants