Add type dependencies

[remcohaszing]

The dependencies on @types/unist and @types/mdast are needed to consume
this package in TypeScript.

If this is not defined, all dependants need to define this dependency.

This would fix the build for remarkjs/remark-rehype#13 and all sava a lot of hassle for its dependants.

[wooorm]

😬 I thought it was the plan to not do typescript dependencies, but keep them in dev deps, so non-ts users (which are many) don’t have to download that? I’ve lost the context.

[remcohaszing]

The context has been spread across multiple projects and pull requests, and spectrum. Putting types in devDependencies has proven to be troublesome, as can be seen in remarkjs/remark-rehype#13.

I think it would be best to discuss this in a centralized location, not this issue, which is one of many TypeScript related issues.

I found an old post on Spectrum that’s related. Although feedback on my several PRs seems to mention the exact opposite of the conclusion there. Should this be discussed further in that post?

[wooorm]

What’s troublesome about that linked issue? The missing types can be installed as a dev dep, no?

I agree. Either Spectrum, or the linked issue: syntax-tree/unist-util-is#14. I was under the impressions that deps was the wrong way to go, dev-deps okay, and potentially also peer-deps.

[ChristianMurphy]

The issue that prompted putting all @types in devDependencies was unifiedjs/unified#45.
With vfile/vfile#54 in place, that issue should be resolved 🤞 😬 .
I'd be open to trying dependencies again.

[wooorm]

Alright, I’d rather have no types for non-ts users, but let’s try it out!

[wooorm]

@remcohaszing @ChristianMurphy patch, minor, major?

[ChristianMurphy]

I think minor, this adds dependencies, but shouldn't break the API. 🤞

[wooorm]

Released as 9.1.0!