Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace link’s href and image’s src with unified url property #8

Closed
wooorm opened this issue Feb 5, 2016 · 5 comments
Closed

Replace link’s href and image’s src with unified url property #8

wooorm opened this issue Feb 5, 2016 · 5 comments
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have

Comments

@wooorm
Copy link
Member

wooorm commented Feb 5, 2016

It seems quite unnecessary to use different properties for a such a similar thing. One url is cleaner and simpler.
@wooorm
Copy link
Member Author

wooorm commented Feb 5, 2016

@eush77 Sorry for all the pings, I just value your brain / input on this :)

@wooorm wooorm added 🙋 no/question This does not need any changes 🙉 open/needs-info This needs some more info labels Feb 5, 2016
@eush77
Copy link
Contributor

eush77 commented Feb 5, 2016

👍 I like this. Consistency is a good thing, and in my opinion HTML terminology is not really applicable here.

@wooorm
Copy link
Member Author

wooorm commented Feb 6, 2016

Hmm, definition uses link. Should that be changed to url too, or should we use link everywhere? (I prefer url more as it’s more correct, link is a bit weird for images)

@eush77
Copy link
Contributor

eush77 commented Feb 6, 2016

I agree, url is a better term.

wooorm added a commit that referenced this issue Feb 6, 2016
@wooorm
Rename link, src, and href properties to url
94fd6d4 
Several different properties were used in different nodes for a single
semantic entity: the URL.  This rename changes that to a unified
`url` property.

*   Rename `link` on `definition` nodes to `url`;
*   Rename `href` on `link` nodes to `url`;
*   Rename `src` on `image` nodes to `url`.

Clsoes GH-8.
@wooorm
Copy link
Member Author

wooorm commented Feb 6, 2016

Closed by 94fd6d4.

@wooorm wooorm closed this as completed Feb 6, 2016
@wooorm wooorm added 🦋 type/enhancement This is great to have 🧑 semver/major This is a change and removed 🙉 open/needs-info This needs some more info 🙋 no/question This does not need any changes labels Feb 6, 2016
@wooorm wooorm mentioned this issue Feb 7, 2016
Closed
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface labels Aug 12, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wooorm @eush77