Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @types/unist to dependencies #19

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Feb 15, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

unist-util-is directly references the unist types (for example here), so it should list it as a dependency. Failing that, loose package managers like npm may generate incorrect hoisting, and strict package managers like Yarn or pnpm may cause TS to fail to resolve the dependency.

Seems related to #14

Fixes the following errors:

unist-util-is/index.d.ts(5,23): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/index.d.ts(8,23): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/index.d.ts(11,23): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(89,25): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(91,16): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(100,27): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(102,16): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(143,23): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(148,27): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(149,29): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(174,23): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(184,23): error TS2307: Cannot find module 'unist' or its corresponding type declarations.
unist-util-is/lib/index.d.ts(202,23): error TS2307: Cannot find module 'unist' or its corresponding type declarations.

Signed-off-by: Maël Nison <nison.mael@gmail.com>
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Feb 15, 2023
@wooorm
Copy link
Member

wooorm commented Feb 15, 2023

Thanks! I’ll get back to the repo in ±10 days as I’m on holiday. OK?

@wooorm wooorm changed the title Adds unist to the dependencies Add @types/unist to dependencies Feb 27, 2023
@wooorm wooorm merged commit 9a1cf2f into syntax-tree:main Feb 27, 2023
@wooorm
Copy link
Member

wooorm commented Feb 27, 2023

Thanks!

@wooorm wooorm added 📦 area/deps This affects dependencies 💪 phase/solved Post is done labels Feb 27, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Feb 27, 2023
@wooorm
Copy link
Member

wooorm commented Feb 27, 2023

released in 5.2.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

3 participants