Failing test: Comma selectors are evaluated independently #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This PR adds a failing test demonstrating what I think is a bug. I wanted to use
hast-util-select
to assign the correct heading path (h1.textContent
→h2.textContent
→p
) to paragraphs on a document. But it looks likeunist-util-select
’sselectAll
essentially evaluatesselector.split(',').flatMap(selectAll)
, resulting in out-of-order results.I noticed that wrapping my selector in
:matches()
causes results to be emitted in the correct order (although doing this prevents me from using nesting selector combinators like>
, so it doesn’t work for my use case).I think this should either be fixed (so that the ordering of results from
:matches(a, b)
anda, b
are the same) or documented as a limitation.