-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
188 changed files
with
5,115 additions
and
6,058 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,35 @@ | ||
## Pull Request template | ||
|
||
Please, go through these steps before you submit a PR. | ||
|
||
1. Make sure that your PR is not a duplicate. | ||
2. If not, then make sure that: | ||
|
||
a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with the issue number as a prefix. | ||
a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with the issue number as a prefix. | ||
|
||
b. You have a descriptive commit message with a short title (first line) following the [conventional commits format](https://www.conventionalcommits.org/en/v1.0.0/) | ||
b. You have a descriptive commit message with a short title (first line) following the [conventional commits format](https://www.conventionalcommits.org/en/v1.0.0/) | ||
|
||
c. You have only one commit (if not, squash them into one commit). | ||
c. You have only one commit (if not, squash them into one commit). | ||
|
||
d. `npm test` doesn't throw any error. If it does, fix them first and amend your commit (`git commit --amend`). | ||
d. `npm test` doesn't throw any error. If it does, fix them first and amend your commit (`git commit --amend`). | ||
|
||
3. **After** these steps, you're ready to open a pull request. | ||
|
||
a. Your pull request MUST NOT target the `master` branch on this repository. You probably want to target `develop` instead. | ||
a. Your pull request MUST NOT target the `master` branch on this repository. You probably want to target `develop` instead. | ||
|
||
b. Give a descriptive title to your PR. | ||
b. Give a descriptive title to your PR. | ||
|
||
c. Provide a description of your changes. | ||
c. Provide a description of your changes. | ||
|
||
d. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes. | ||
d. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes. | ||
|
||
IMPORTANT: Please review the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines. | ||
|
||
**PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING** | ||
|
||
|
||
|
||
# [Title] | ||
|
||
- [x] Change 1 | ||
- [x] Change 2 | ||
|
||
closes #XXXX | ||
closes #XXXX |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.