Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant pool #160

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Constant pool #160

merged 7 commits into from
Aug 2, 2023

Conversation

mitchellolsthoorn
Copy link
Member

@mitchellolsthoorn mitchellolsthoorn commented Aug 2, 2023

This PR adds a constant pool to the JavaScript testing module. It searches for constants in the context root and stores these in a pool. This pool is then used for seeding the sampler.

@mitchellolsthoorn mitchellolsthoorn requested a review from a team as a code owner August 2, 2023 10:59
@mitchellolsthoorn mitchellolsthoorn linked an issue Aug 2, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@dstallenberg dstallenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we only need to edit the decoder to make sure we do not use invalid characters.

@mitchellolsthoorn mitchellolsthoorn mentioned this pull request Aug 2, 2023
Copy link
Contributor

@dstallenberg dstallenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@dstallenberg dstallenberg merged commit 02f0aaf into main Aug 2, 2023
5 of 6 checks passed
@dstallenberg dstallenberg deleted the feat-constant-pool branch August 2, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constantpool
3 participants