Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor type model #194

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Refactor type model #194

merged 6 commits into from
Dec 11, 2023

Conversation

dstallenberg
Copy link
Contributor

Removed the maps in the typemodel class and created a TypeNode object

@dstallenberg dstallenberg requested a review from a team as a code owner October 30, 2023 14:56
@dstallenberg dstallenberg changed the base branch from main to feat-cache-type-model October 30, 2023 14:57
Base automatically changed from feat-cache-type-model to main December 11, 2023 16:12
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7170281385

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 66 of 192 (34.38%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 46.959%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/plugin-javascript-event-listener-state-storage/lib/StateStorage.ts 0 4 0.0%
libraries/analysis-javascript/lib/type/resolving/TypeModel.ts 18 34 52.94%
libraries/analysis-javascript/lib/type/resolving/TypeNode.ts 34 140 24.29%
Files with Coverage Reduction New Missed Lines %
plugins/plugin-javascript-event-listener-state-storage/lib/StateStorage.ts 2 12.5%
Totals Coverage Status
Change from base Build 7170212173: 0.5%
Covered Lines: 1553
Relevant Lines: 3063

💛 - Coveralls

@dstallenberg dstallenberg merged commit 4db8493 into main Dec 11, 2023
12 checks passed
@dstallenberg dstallenberg deleted the fix-refactor-type-model branch December 11, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants