Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make db requirements optional #110

Merged
merged 10 commits into from
Mar 10, 2023
Merged

Make db requirements optional #110

merged 10 commits into from
Mar 10, 2023

Conversation

simonhkswan
Copy link
Contributor

Now you can install the requirements for connecting to a DB optionally. e.g.

pip install 'insight[db]'

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #110 (ab0d365) into master (a318a2e) will decrease coverage by 0.9%.
The diff coverage is 81.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #110     +/-   ##
========================================
- Coverage    80.1%   79.3%   -0.9%     
========================================
  Files          11      11             
  Lines         850     870     +20     
  Branches      156     130     -26     
========================================
+ Hits          681     690      +9     
- Misses        130     140     +10     
- Partials       39      40      +1     
Impacted Files Coverage Δ
src/insight/database/utils.py 75.3% <20.0%> (-6.3%) ⬇️
src/insight/metrics/base.py 75.0% <45.4%> (-3.6%) ⬇️
src/insight/plot.py 68.6% <89.6%> (ø)
src/insight/__init__.py 100.0% <100.0%> (ø)
src/insight/database/schema.py 100.0% <100.0%> (ø)

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

61.5% 61.5% Coverage
0.0% 0.0% Duplication

@simonhkswan simonhkswan self-assigned this Mar 10, 2023
@simonhkswan simonhkswan merged commit 69d43ba into master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant