Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the direct dtype conversion in zipped_hist #152

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Added the direct dtype conversion in zipped_hist #152

merged 1 commit into from
Oct 26, 2023

Conversation

marqueewinq
Copy link
Contributor

Closes #151

@marqueewinq marqueewinq self-assigned this Oct 26, 2023
@marqueewinq marqueewinq linked an issue Oct 26, 2023 that may be closed by this pull request
TypeError for columns with dtype=object that could be inferred as numeric dtype #151
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #152 (c447016) into master (d13a4f4) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #152   +/-   ##
======================================
  Coverage    79.5%   79.5%           
======================================
  Files          11      11           
  Lines         890     892    +2     
  Branches      135     136    +1     
======================================
+ Hits          708     710    +2     
  Misses        140     140           
  Partials       42      42
Files Coverage Δ
src/insight/metrics/utils.py 64.4% <100.0%> (+1.6%) ⬆️

hamishteagle
hamishteagle approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@hamishteagle hamishteagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@marqueewinq marqueewinq merged commit 5623e65 into master Oct 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishteagle hamishteagle hamishteagle approved these changes

Assignees

@marqueewinq marqueewinq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError for columns with dtype=object that could be inferred as numeric dtype
2 participants
@marqueewinq @hamishteagle