Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added KSD #156

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Added KSD #156

merged 2 commits into from
Nov 22, 2023

Conversation

marqueewinq
Copy link
Contributor

@marqueewinq marqueewinq commented Nov 22, 2023 •
edited
Loading

Added Kolmogorov-Smirnov Distance & tests.

Also sorted the imports in __init__.py

@marqueewinq marqueewinq self-assigned this Nov 22, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Merging #156 (bacbdc0) into master (259a874) will increase coverage by 0.0%.
The diff coverage is 85.7%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #156   +/-   ##
======================================
  Coverage    79.5%   79.6%           
======================================
  Files          11      11           
  Lines         892     905   +13     
  Branches      136     139    +3     
======================================
+ Hits          710     721   +11     
- Misses        140     141    +1     
- Partials       42      43    +1
Files Coverage Δ
src/insight/metrics/__init__.py 100.0% <ø> (ø)
src/insight/metrics/metrics.py 91.1% <85.7%> (-0.4%) ⬇️

tomcarter23
tomcarter23 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@tomcarter23 tomcarter23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@marqueewinq marqueewinq merged commit 68dc221 into master Nov 22, 2023
6 checks passed
@marqueewinq marqueewinq deleted the kolmogorov-smirnov-distance branch November 22, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomcarter23 tomcarter23 tomcarter23 approved these changes

Assignees

@marqueewinq marqueewinq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marqueewinq @tomcarter23