Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed check.continuous to accept int32, float32 and uint32 #159

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

marqueewinq
Copy link
Contributor

The following code produced "Number of categories exceeded threshold" message if any of dfs contained any of the types int32, float32, uint32:

from insight import plot as p
fig = p.dataset([df_eval, df_synth_eval])

This PR fixes the incorrect behaviour + adds a failing test.

@marqueewinq marqueewinq self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f19bc5) 79.9% compared to head (a644dbf) 79.9%.

❗ Current head a644dbf differs from pull request most recent head bf4051a. Consider uploading reports for the commit bf4051a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #159   +/-   ##
======================================
  Coverage    79.9%   79.9%           
======================================
  Files          11      11           
  Lines         927     927           
  Branches      145     145           
======================================
  Hits          741     741           
  Misses        142     142           
  Partials       44      44           
Files Coverage Δ
src/insight/check.py 88.4% <ø> (ø)

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@marqueewinq marqueewinq merged commit 91c70df into master Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants