Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin requirements for CI testing #173

Merged
merged 10 commits into from
Feb 7, 2024
Merged

Conversation

simonhkswan
Copy link
Contributor

Pinning the requirements to requirements.txt will keep the CI more stable and reliable.

@simonhkswan simonhkswan self-assigned this Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f0a489) 78.6% compared to head (db58d1e) 78.6%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #173   +/-   ##
======================================
  Coverage    78.6%   78.6%           
======================================
  Files          11      11           
  Lines         970     970           
  Branches      161     161           
======================================
  Hits          763     763           
  Misses        154     154           
  Partials       53      53           

Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

.github/workflows/CI.yaml Show resolved Hide resolved
.github/workflows/CI.yaml Show resolved Hide resolved
.github/workflows/CI.yaml Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
Copy link
Member

@tomcarter23 tomcarter23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@simonhkswan simonhkswan merged commit 5f215f8 into master Feb 7, 2024
5 checks passed
@simonhkswan simonhkswan deleted the pin-testing-requirements branch February 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants