Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducible IDs for FHIR resources and CCDA elements. #760

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

hadleynet
Copy link
Collaborator

This pull request builds on recent work to improve the reproducibility of generated records when using the same patient seed, provider seed and reference date. This pull request introduces reproducible resource and element ids so diffing two sets of generated patients will not yield differences resulting from random ids.

To test:

./run_synthea -p 10 -s 5 -cs 10 -r 20200701
mv output/fhir output/fhir2
./run_synthea -p 10 -s 5 -cs 10 -r 20200701

Diff the corresponding files in output/fhir and output/fhir2.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #760 into master will decrease coverage by 0%.
The diff coverage is 87%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #760   +/-   ##
========================================
- Coverage        81%     81%   -1%     
- Complexity     2693    2711   +18     
========================================
  Files           101     101           
  Lines         16856   16866   +10     
  Branches       2325    2325           
========================================
- Hits          13701   13679   -22     
- Misses         2445    2490   +45     
+ Partials        710     697   -13     
Impacted Files Coverage Δ Complexity Δ
.../main/java/org/mitre/synthea/engine/Generator.java 80% <0%> (-3%) 63 <0> (-2)
.../org/mitre/synthea/export/FhirGroupExporterR4.java 11% <0%> (ø) 3 <0> (ø)
...tre/synthea/export/FhirPractitionerExporterR4.java 5% <0%> (ø) 2 <0> (ø)
...g/mitre/synthea/helpers/RandomNumberGenerator.java 42% <ø> (ø) 6 <0> (ø)
.../java/org/mitre/synthea/world/agents/Provider.java 89% <ø> (+<1%) 55 <0> (+1)
...va/org/mitre/synthea/world/geography/Location.java 72% <ø> (ø) 46 <0> (ø)
...in/java/org/mitre/synthea/datastore/DataStore.java 82% <85%> (-5%) 28 <0> (-1)
...c/main/java/org/mitre/synthea/export/FhirStu3.java 84% <89%> (+<1%) 155 <1> (+3)
src/main/java/org/mitre/synthea/export/FhirR4.java 86% <93%> (+<1%) 191 <1> (+2)
.../main/java/org/mitre/synthea/export/FhirDstu2.java 87% <94%> (+2%) 116 <1> (+3)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89aa966...38bd88d. Read the comment docs.

@eedrummer eedrummer merged commit 6e4507a into master Aug 5, 2020
@eedrummer eedrummer deleted the id-reproducibility branch August 5, 2020 13:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants