Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpos precision loss in inches mode #296

Open
MitchBradley opened this issue Oct 23, 2017 · 9 comments
Open

wpos precision loss in inches mode #296

MitchBradley opened this issue Oct 23, 2017 · 9 comments
Assignees
@giseburt
Labels
enhancement

Comments

@MitchBradley
Copy link
Contributor

In inches mode, the work position report precision is 3 decimal places, which is not enough for some machines. That results in imprecise position displays, loss of reports (when position changes are filtered out because of changes smaller than EPSILON3), and jog granularity problems.

I have a fix for this problem and will submit a pull request after I have cleaned up the changes.
@giseburt
Copy link
Member

Sounds good. Thank you for catching this.

@giseburt giseburt self-assigned this Oct 23, 2017
MitchBradley pushed a commit to MitchBradley/g2 that referenced this issue Oct 23, 2017
Inch mode precision fixes (synthetos#296)
ac62a3d 
Reports in inches need 3 more decimal places than in mm.
This patch fixes that, while ensuring that every NV object
of TYPE_FLOAT has nv->precision set to a definite value.
The static precision values in the configuration table
are left as-is, dynamically modifying nv->precision in
created objects according to the mm/inches mode.

It also fixes a related problem, in which position changes
sometimes went unreported because of rollover boundary
issues.
@MitchBradley MitchBradley mentioned this issue Oct 23, 2017
Closed
@justinclift
Copy link
Member

@MitchBradley Guessing you've been using a version of g2core with your patch included, for a few months now. If that's the case, are the extra decimal places working out as hoped? 😄

Just thinking it might be useful to get some feedback on the change from someone's who's probably actually been using it in reality for a while now, just in case you feel your patch could do with some subsequent tweaking. 😁

@MitchBradley
Copy link
Contributor Author

Yes, I have been using it in production with no problems. The parts are coming off the line ...

@justinclift
Copy link
Member

justinclift commented Apr 11, 2018 •
edited
Loading

Awesome. What sort of parts are you making? 😄

@ril3y
Copy link
Member

ril3y commented Apr 13, 2018 via email •
edited by justinclift
Loading

@MitchBradley
Copy link
Contributor Author

I make golf putters from bamboo. There is a time-lapse video at
https://www.youtube.com/watch?v=yoLG7eB8SuI

In that video, the milling is done with Mach3 but since then I have built a new shop that is specialized for putters, converted my Taig mill to a g2core/Due/RaspberryPi/cncjs controller, and added several cnc processes to replace manual shaping.

@ril3y
Copy link
Member

ril3y commented Apr 13, 2018 via email •
edited by justinclift
Loading

@justinclift
Copy link
Member

Excellent! We'd better make a page on the wiki that showcases stuff being created with g2core.

This should go on there. 😄

@justinclift
Copy link
Member

New "g2core in use" page created here:

    https://github.com/synthetos/g2/wiki/g2core-in-use

Not 100% sure of the wording, layout, etc, but it seems like a reasonable start. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giseburt giseburt

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ril3y @giseburt @justinclift @MitchBradley