-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get annotations in pages #41
Conversation
A new version of the api in app-service will require an offset argument from ~Aug-2023.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the fetch_all_pages architecture, allows us to reuse this if we need to paginate other endpoints
904adf5
to
aad1613
Compare
Discussed yesterday with @duaneallam , we're happy to merge. This will get published at some point but only after we've deployed the pagination change to app-service. This change means the "get annotations" endpoint in app-service will now only return first page of results if you don't specify an offset. |
A new version of the api in app-service will require an offset argument from ~Aug-2023.