Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get annotations in pages #41

Merged
merged 9 commits into from
Aug 30, 2023
Merged

Conversation

danielbush
Copy link
Contributor

A new version of the api in app-service will require an offset argument from ~Aug-2023.

A new version of the api in app-service will require an offset argument from ~Aug-2023.
@danielbush danielbush temporarily deployed to deploy August 18, 2023 00:39 — with GitHub Actions Inactive
@danielbush danielbush temporarily deployed to deploy August 18, 2023 01:09 — with GitHub Actions Inactive
Copy link
Contributor

@duaneallam duaneallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the fetch_all_pages architecture, allows us to reuse this if we need to paginate other endpoints

@danielbush danielbush temporarily deployed to deploy August 18, 2023 14:37 — with GitHub Actions Inactive
@danielbush danielbush temporarily deployed to deploy August 28, 2023 07:04 — with GitHub Actions Inactive
@danielbush danielbush temporarily deployed to deploy August 28, 2023 07:44 — with GitHub Actions Inactive
@danielbush danielbush force-pushed the feat/get-annotations-in-pages branch from 904adf5 to aad1613 Compare August 28, 2023 07:48
@danielbush danielbush temporarily deployed to deploy August 28, 2023 07:48 — with GitHub Actions Inactive
@danielbush danielbush temporarily deployed to deploy August 28, 2023 22:56 — with GitHub Actions Inactive
@danielbush danielbush temporarily deployed to deploy August 28, 2023 23:05 — with GitHub Actions Inactive
@danielbush danielbush temporarily deployed to deploy August 29, 2023 07:38 — with GitHub Actions Inactive
@danielbush
Copy link
Contributor Author

Discussed yesterday with @duaneallam , we're happy to merge. This will get published at some point but only after we've deployed the pagination change to app-service. This change means the "get annotations" endpoint in app-service will now only return first page of results if you don't specify an offset.

@danielbush danielbush merged commit 89cbd92 into master Aug 30, 2023
2 checks passed
@danielbush danielbush deleted the feat/get-annotations-in-pages branch August 30, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants