Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assertion exception shows error at correct location #402

Merged
merged 3 commits into from
Oct 30, 2020
Merged

fix: assertion exception shows error at correct location #402

merged 3 commits into from
Oct 30, 2020

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Oct 30, 2020

Description

Before

Screen Shot 2020-10-30 at 12 52 49 AM

After

Screen Shot 2020-10-30 at 12 48 33 AM

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

No additional comments.

@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #402   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          992      1001    +9     
=========================================
+ Hits           992      1001    +9

@iamogbz iamogbz requested a review from noahnu October 30, 2020 04:56
noahnu
noahnu approved these changes Oct 30, 2020
View reviewed changes
Copy link
Collaborator

@noahnu noahnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM because it's an improvement, although the remainder of the stack trace isn't useful.

@iamogbz iamogbz merged commit d46bba4 into master Oct 30, 2020
@iamogbz iamogbz deleted the fix-show-assertion-exception branch October 30, 2020 14:27
syrupy-bot pushed a commit that referenced this pull request Oct 30, 2020
@semantic-release-bot
chore(release): 0.8.3 [skip ci]
5c77f44 
## [0.8.3](v0.8.2...v0.8.3) (2020-10-30)

### Bug Fixes

* assertion exception shows error at correct location ([#402](#402)) ([d46bba4](d46bba4))
* only perform session finish on test items ran ([#401](#401)) ([61a670f](61a670f))
@syrupy-bot
Copy link
Contributor

🎉 This PR is included in version 0.8.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahnu noahnu noahnu approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamogbz @syrupy-bot @noahnu