-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: handle case where both pyargs and test file given #510
Conversation
result = run_testcases.runpytest( | ||
"-v", "test_file.py", "--pyargs", "test_file", "--snapshot-update" | ||
) | ||
assert result.ret == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would fail with ModuleNotFoundError: No module named 'test_file.py'; 'test_file' is not a package
if the Exception
was not handled.
pull request head sha does not match latest commit
.github/workflows/cicd.yml
Outdated
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
# Github pull request event has the merge commit as the HEAD on checkout | ||
# https://github.com/actions/checkout/issues/261 | ||
COMMIT_SHA: ${{ github.event.after }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using COMMIT_SHA
as GITHUB_SHA
does not seem to be overridable
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Add missing test coverage for #507
Checklist
Additional Comments
No additional comments.