Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): explicit property matcher and filter types kwargs #515

Merged
merged 3 commits into from
Jun 5, 2021

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Jun 5, 2021

Description

  • Improves the typing of PropertyMatcher and PropertyFilter
  • Makes DataSerializer methods explicit about accepted types

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

No additional comments.

@iamogbz iamogbz requested a review from noahnu June 5, 2021 20:56
@iamogbz iamogbz changed the title feat(types): make property matcher and filter types explicit about kwargs feat(types): explicit property matcher and filter types kwargs Jun 5, 2021
@iamogbz iamogbz merged commit 8dddebf into master Jun 5, 2021
@iamogbz iamogbz deleted the fix-typing branch June 5, 2021 21:03
tophat-opensource-bot pushed a commit that referenced this pull request Jun 5, 2021
# [1.3.0](v1.2.4...v1.3.0) (2021-06-05)

### Features

* **types:** explicit property matcher and filter types kwargs ([#515](#515)) ([8dddebf](8dddebf))
@tophat-opensource-bot
Copy link
Collaborator

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants