fix: unused snapshot not filtered out when specific node #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnu
changed the title
noahnu
commented
Aug 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
===========================================
- Coverage 100.00% 99.91% -0.09%
===========================================
Files 19 19
Lines 1105 1114 +9
===========================================
+ Hits 1105 1113 +8
- Misses 0 1 +1 |
noahnu
changed the title
noahnu
commented
Aug 18, 2021
Comment on lines
+204
to
+207
| and self._provided_nodes_match_name( | ||
| snapshot_location=snapshot_location, | ||
| snapshot_name=snapshot.name, | ||
| provided_nodes=provided_nodes, |
There was a problem hiding this comment.
This bit might actually be dead code. It's never hit in tests. I don't think it's harmful at the moment, so will loop back to see if it can be removed, or if there's some edge case we're not testing.
noahnu
commented
Aug 18, 2021
Comment on lines
+362
to
+367
| if not provided_nodes: | ||
| return True | ||
| for node_path in provided_nodes: | ||
| if snapshot_name in ".".join(node_path): | ||
| return True | ||
| return False |
There was a problem hiding this comment.
This syntax is easier to debug.
noahnu
commented
Aug 18, 2021
| "test_2.py::test_a", | ||
| ) | ||
| result.stdout.re_match_lines("2 snapshots passed") | ||
| assert result.ret == 0 |
There was a problem hiding this comment.
Duplicated this test file since locations for images are handled a bit differently, better safe than sorry.
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues