fix: NameError when importing SingleFileSnapshotExtension #557
Conversation
If you try to import `SingleFileSnapshotExtension` it will raise `NameError: name 'SerializedData' is not defined` because SerializedData is only imported if type checking and the return type annotation was not quoted.
Example:
```
>>> from syrupy.extensions.single_file import SingleFileSnapshotExtension
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/jocke/projects/syrupy/src/syrupy/extensions/single_file.py", line 26, in <module>
class SingleFileSnapshotExtension(AbstractSyrupyExtension):
File "/Users/jocke/projects/syrupy/src/syrupy/extensions/single_file.py", line 33, in SingleFileSnapshotExtension
) -> SerializedData:
NameError: name 'SerializedData' is not defined
```
joakimnordling
force-pushed
the
bugfix/fix-import-problem
branch
from
88a339c
to
c18e176
Compare
|
@all-contributors add @joakimnordling for bug fix |
|
I've put up a pull request to add @joakimnordling! 🎉 |
|
Thank you for the fix! Unfortunately the CI pipeline seems to be broken: https://github.com/tophat/syrupy/runs/3881842927. Not sure what's happening as I published successfully a week ago. Maybe something changed in the github hosted runners. I'll take a look at some point today so hopefully we can get this released. |
## [1.4.7](v1.4.6...v1.4.7) (2021-10-13) ### Bug Fixes * NameError when importing SingleFileSnapshotExtension ([#557](#557)) ([935e256](935e256))
|
🎉 This PR is included in version 1.4.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No problem and thanks for quickly incorporating the fix and getting it released! It allowed me to now get the latest version in use instead of pinning to 1.4.5. |
Description
Fixes the following issue:
If you try to import
SingleFileSnapshotExtensionit will raiseNameError: name 'SerializedData' is not definedbecause SerializedData is only imported if type checking and the return type annotation was not quoted.Example: