generated from tophat/new-project-kit
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate Syrupy v4 pre-release #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 99.54% 98.29% -1.25%
==========================================
Files 20 20
Lines 1326 1410 +84
==========================================
+ Hits 1320 1386 +66
- Misses 6 24 +18 |
noahnu
force-pushed
the
next
branch
3 times, most recently
from
August 11, 2022 21:28
5d8631e
to
34d9871
Compare
noahnu
force-pushed
the
next
branch
5 times, most recently
from
November 8, 2022 23:11
6d17701
to
3279e90
Compare
noahnu
force-pushed
the
next
branch
2 times, most recently
from
November 30, 2022 21:02
fc19e85
to
3325b3c
Compare
noahnu
force-pushed
the
next
branch
4 times, most recently
from
December 30, 2022 18:18
1c6cfb8
to
1445f9b
Compare
* fix: group snapshot writes by extension class * refactor: rename PyTestLocation.filename to .basename BREAKING CHANGE: PyTestLocation.filename has been renamed to .basename * refactor: add test_location kwarg to get_snapshot_name * refactor: get_snapshot_name is now static as a classmethod * refactor: remove pre and post read/write hooks BREAKING CHANGE: Pre and post read/write hooks have been removed without replacement to make internal refactor simpler. Please open a GitHub issue if you have a use case for these hooks. * refactor: rename Fossil to Collection BREAKING CHANGE: The term 'fossil' has been replaced by the clearer term 'collection'. * refactor: pass test_location to read_snapshot * refactor: remove singular write_snapshot method * refactor: dirname property to method * refactor: pass test_location to discover_snapshots * refactor: remove usage of self.test_location * refactor: make write_snapshot a classmethod * refactor: do not instantiate extension with test_location BREAKING CHANGE: Numerous instance methods have been refactored as classmethods.
BREAKING CHANGE: Raise minimum python version to 3.8.1 and min. pytest version to v7.
NOTE: When pytest-xdist is detected, we do not remove unused snapshots, since that requires coordination between the workers and the controller. A disclaimer has been added to the README and TODO comments added to the source code to help solve this problem at some point.
BREAKING CHANGE: The JSONSnapshotExtension now serializes Python's None as "null" rather than "None".
BREAKING CHANGE: Key order is now preserved if using OrderedDict in both the Amber serializer and JSON serializer.
* refactor: simplify data serializer for ambr * feat: introduce concept of a tainted snapshot BREAKING CHANGE: Serializers may now throw a TaintedSnapshotError which will tell the user to regenerate the snapshot even if the underlying data has not changed. This is to support rolling out more subtle changes to the serializers, such as the introduction of serializer metadata. BREAKING CHANGE: Renamed DataSerializer to AmberDataSerializer.
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Performance
Breaking Changes
Requirements
Bug Fixes
Serializers
null
. (JSONSnapshotExtension None is serialized as "None" instead of null #622)pytest --snapshot-update
. This version marker is being placed to make it simpler to support multiple versions of the amber serializer, and thus rollout what has previously been considered breaking changes, without queueing for a major version update.Extensions API