fix: avoid reporting crash for snapshot dir outside pytest dir #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnu
approved these changes
Sep 20, 2022
tophat-opensource-bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
## [3.0.1](v3.0.0...v3.0.1) (2022-09-20) ### Bug Fixes * avoid reporting crash for snapshot dir outside pytest dir ([#621](#621)) ([f2b2e77](f2b2e77))
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Yay, thanks! |
tophat-opensource-bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
## [3.0.1](v3.0.0...v3.0.1) (2022-09-23) ### Bug Fixes * avoid reporting crash for snapshot dir outside pytest dir ([#621](#621)) ([f2b2e77](f2b2e77))
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the formatting code for the unused snapshots less strict, to stop the detailed reporting (e.g.
--snapshot-detailsor--snapshot-update) crashing when there's unused snapshots in a directory that's outside the main pytest session root directory.The display is less good when this comes up, since it's the full path, rather than trimmed to a more relevant section, but it's better than crashing entirely!
Related Issues
Checklist
Additional Comments
No additional comments.