-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix french maintenance translation (inverted entries) #340
Fix french maintenance translation (inverted entries) #340
Conversation
WalkthroughThe pull request involves updates to the French localization file for a frontend application, specifically correcting error messages related to maintenance operations. The changes include adjustments to the Changes
Possibly related PRs
Security Recommendations
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)frontend/locales/fr.json (2)Line range hint ✅ The translation changes:
The changes properly fix the inverted translations:
Let's verify the translations are consistent with other language files: ✅ Verification successfulFrench translations are now correctly aligned with other language files The verification confirms that the French translations for "failed_to_create" and "failed_to_delete" are now semantically consistent with all other language files in the repository:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if other language files have consistent translations for these keys
# This helps ensure the French translations align with other languages
# Search for failed_to_create and failed_to_delete keys in all locale files
echo "Checking translations in other language files..."
fd -e json . frontend/locales -x jq -r '.maintenance.toast | select(.failed_to_create != null or .failed_to_delete != null) | {file: input_filename, create: .failed_to_create, delete: .failed_to_delete}'
Length of output: 2318 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
What type of PR is this?
What this PR does / why we need it:
Fixed inverted translation entries.
Summary by CodeRabbit