-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable native/true multitouch gestures #10
Conversation
…ehabMan#77); bump version 1.8.27
…f code by monitoring IOUSBInterface
…dd SSDT-HPFixLidSleep.dsl for others; bump version 1.8.29
…cleanup other ACPI examples
… hardware reset in the start function, and knowing whether or not we're dealing with a thinkpad machine with three physical buttons.
…kpad laptops with the trackpoint/nub. All of the code added only works if "Thinkpad=true" in the info.plist or specified in ACPI so these changes will not mess up or change anything for other machine types.
…rom tlucks edits. Nothing major, room for expansion, working well :)
…th vps2_findmousedelay; bump version 1.8.30
…add Thinkpad .dsl examples; bump version 1.8.31
Catching up
…100; bump version 1.8.33
…subsequent selections)
…ehabMan#166); bump version 1.9.1
For some people, such as myself, it wasn't obvious the device path should have "RMCF" appended. Hopefully this can help prevent other people having this issue in future.
Add comment detailing possible modifications
Hi thank you so much! I want to merge it but it shows merge conflicts 😟 |
1 similar comment
Hi thank you so much! I want to merge it but it shows merge conflicts 😟 |
I’ll rebase and apply some additional clean up so there aren’t conflicts with master. |
Awesome! I will test it today then merge it! |
Few things to note:
|
Nice! As for the renaming, sounds good to me:) |
Hi @kprinssu , I've tested it on my Precision M3800, and this driver is really good! In short, the two finger gestures (left/right swipe forward/back), three finger taps, dragging, work like a charm. I have a MacBookPro 13, 2018 with Touch Bar, and I feel these touchpad is quite usable now! Thank you so much! |
@kprinssu could you please tell me why this implementation will make the touchpad much precise and smoother, I'm really looking forward to the details. Thank you in advance! |
Good to hear! I still find that it still abit jerky and will require more tuning. There are more changes from VoodooI2C that I want to backport but this PR should be good to go, unless you want me to clean up code. |
Thank you, I've already submitted a collaboration request for you 😃 |
I am creating this PR to show that it is possible to enable native multitouch on PS/2 trackpads. My laptop comes with a Synaptics PS/2 trackpad and this is a more of a PoC than anything else.
A lot of the work here was hacked together using VoodooI2C's native multi touch engine (though it's from an older commit) and the synaptics driver from the Linux kernel.
It currently supports 3+ fingers gestures so it should fully support most of Macbooks gesture. However, my laptop only seems to support a max of three fingers and gestures sometimes feel off.
I also had emulate the third finger since the trackpad doesn't report back on more than 2 fingers.
Based on Rehabman's upstream branch, but should be relatively easy to backport the changes. Feel free to edit and merge the code at your leisure.