🌱 Reduce reconcilements #1359
Merged
🌱 Reduce reconcilements #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batistein
previously approved these changes
Jun 21, 2024
janiskemper
force-pushed
the
reduce-reconcilements
branch
from
3cc9b66
to
28c641c
Compare
apricote
reviewed
Jun 21, 2024
janiskemper
force-pushed
the
reduce-reconcilements
branch
2 times, most recently
from
cc156c7
to
0cd4ab0
Compare
syself-bot
bot
added
the
size/L
- Filter HCloudMachine events so that status updates of the resource don't trigger another reconcilement of HCloudMachine - Filter HetznerCluster events so that status updates of the resource don't trigger another reconcilement of HetznerCluster - Filter HetznerCluster events so that some status updates that are not important don't trigger reconcilement of HCloudMachine - Filter Machine events so that status updates of the resource don't trigger another reconcilement of HCloudMachine a - Filter Cluster events so that status updates of the resource don't trigger another reconcilement of HetznerCluster - Increase the time period to requeue if a server is starting - Increase the time period to requeue if a server has not status yet - Increase the time period to requeue if the kubeapi server is not yet reachable before adding it as target to the load balancer - Don't trigger multiple shutdown calls for one server and increase the timeout to requeue after a shutdown is triggered
janiskemper
force-pushed
the
reduce-reconcilements
branch
from
0cd4ab0
to
be23ff4
Compare
apricote
approved these changes
Jun 24, 2024
batistein
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
TODOs:
Side note:
I will add an issue for unit testing the functions I have added after this is getting merged.