Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update to cluster API v1.7.4 #1384

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

kranurag7
Copy link
Contributor

this commit updates CAPH to latest release of cluster API which is v1.7.4

// cc @janiskemper (kubeadm v1beta4 types kubernetes-sigs/cluster-api#10771)

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

this commit updates CAPH to latest release of cluster API which is
v1.7.4

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Copy link
Contributor

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kranurag7 :)

@janiskemper janiskemper marked this pull request as ready for review July 11, 2024 07:18
@janiskemper
Copy link
Contributor

@kranurag7 do we have to do something about this? kubernetes-sigs/cluster-api#10771

@syself-bot syself-bot bot added area/hack Changes made in the hack directory area/test Changes made in the test directory labels Jul 11, 2024
@kranurag7
Copy link
Contributor Author

@kranurag7 do we have to do something about this? kubernetes-sigs/cluster-api#10771

Not immediately for sure but still I wanted to bring this to attention. This page is a good reference for looking into what's new in v1beta4 API.

Ref: https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta4/

CAPI supports it starting v1.7.4 so we can use more secure EncryptionAlgorithm (I remember a scanner was flagging this out at runtime). This is the one that's coming top of my head.

@batistein batistein merged commit b9b1f9c into syself:main Jul 23, 2024
14 checks passed
@kranurag7 kranurag7 deleted the kr/capi-1.7.4 branch July 23, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hack Changes made in the hack directory area/test Changes made in the test directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants