Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Refactor hcloudcontroller tests #904

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

janiskemper
Copy link
Contributor

What this PR does / why we need it:
Refactoring tests of hcloud controller to better re-use objects, add useful comments, remove unnecessary code and improve naming

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Refactoring tests of hcloud controller to better re-use objects, add
useful comments, remove unnecessary code and improve naming
@syself-bot syself-bot bot added size/L Denotes a PR that changes 200-800 lines, ignoring generated files. area/code Changes made in the code directory labels Sep 12, 2023
@janiskemper janiskemper merged commit 336d56b into main Sep 12, 2023
6 of 8 checks passed
@janiskemper janiskemper deleted the refactor-hcloudcontroller-tests branch September 12, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory size/L Denotes a PR that changes 200-800 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant