-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React 16 #387
Upgrade to React 16 #387
Conversation
Enzyme is not ready for React 16, so tests are disabled
Web and Mobile part works for me, though more thorough checking is needed. The only thing that is not working is UI tests, due to Enzyme issues |
# Conflicts: # package.json
# Conflicts: # package.json
@Vlasenko https://github.com/airbnb/enzyme just got updated to |
@mitjade Many thanks for the hint Mitja! I will check now |
@mitjade Okay, I have tried, it doesn't work for me with React 16. Well it kinda works but have lots of bugs, that makes it usage impractical |
@mitjade So Enzyme v3 has problems with traversing React 16 tree. Except UI tests, everything else works fine in this branch. |
@Vlasenko Great! Hopefully it will get fixed by the time |
@mitjade I plan to do this right on the day when React 16 get finally released, if Enzyme will be usable on that date as well. |
@Vlasenko Sound good. |
@mitjade Yes, I saw React 16 release. But Enzyme@3 doesn't work for me neither for React 16 nor for React 15.4 |
Enzyme 3 is not working properly with React 16 at the moment: @mairh @mitjade What should we do? Wait for the fix, or disable UI tests for now and merge this PR? |
I think if we wait more this PR will go into the stale mode and probably you will end up fixing all other packages based on their future updates. So, I'll say merge this and disable the tests for now. |
I am sure you have noticed the merge conflicts in this PR. |
This is an early attempt to upgrade the kit to React 16. The full upgrade will be ready when all dependencies are ready for React 16, or when alternatives found for these dependencies.
Enzyme is not ready for React 16, so tests are disabled for now.