[#89] Add SSE Send Timeout #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* a client connection that is not read from can block the SSE server task.
|
@blodow, thank you for this PR, much appreciated! Please give me some time to review it properly. |
|
@blodow , following feedback
After upgrade dependecies:
At this point I need to stop due to time constraints. However, |
|
@sysid I think I managed to fix the remaining issues in a sort of minimally-invasive way. Let me know if you would like to see any other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #89, this adds a
send_timeoutparameter to theEventSourceResponseinitializer. In the event of thesendcall inside the response's sending logic exceeding this duration, aSendTimeoutErroris raised, aborting the SSE event generator and effectively canceling the HTTP connection.