Reworking of SET parser #4274
Merged
Reworking of SET parser #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setparser_test_common.h includes the tests for both setparser_test2.cpp and setparser_test3.cpp
Disabling jemalloc from TAP tests it saves around 5MB per binary Also renamed proxysql_find_charset_collate() in proxysqlTap_find_charset_collate()
Added set_query() to change the query. parse1v2() is now able to only once: - generate the pattern - compile the regex
If parse1() or parse1v2() is not able to parse the whole query, it doesn't return any result (thus causes an error)
Variable mysql-set_parser_algorithm defines which algorithm is used by SetParser for the parsing of SET statements. If value is 1: parse1() is used If value is 2: parse1v2() is used parse1v2() allows also the using a single SetParser per MySQL_Thread to process all SET statements. Regex is compiled only once. set_testing-240-t was also modified to test both algorithms
|
retest this please |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.