Add support for hostgroup_attributes for AWS Aurora auto-discovery
#4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for autodiscovery for GR for MySQL8. - Allow to configure autodiscovered servers defaults via 'mysql_hostgroup_attributes'. - Add support for GR autodiscovery for Cluster Simulator. - Improve server 'viable_candidate' detection for MySQL 8, 'RECOVERING' state is now also considered.
…rvers In case an autodiscovered server is found 'OFFLINE_HARD', the recovery logic now properly updates the 'servers_defaults' values for the server, in the same way as for a new discovered server.
Since the same 'AWS_Aurora_status_entry' index was being used for computing the previous and current statuses, no difference was being found, and no action taken.
When a writer is also placed in the reader hostgroup due to 'writer_is_also_reader', this new reader should also honor 'new_reader_weight'.
- Refactor of 'commit' checksums computation. - Refactor update of 'AWS_Aurora_Hosts_resultset'. - Fix invalid use of SHUNNED|SHUNNED_REPLICATION_LAG servers for checksum computation via 'MYSQL_SERVERS_CHECKSUM_QUERY'.
- Preserve old simulator behavior via 'TEST_AURORA_RANDOM' macro. - Add new deterministic behavior for testing particular scenarios. - Add support for simulating multiple clusters via an updated 'REPLICA_HOST_STATUS' table and hostgroup based selection. - Provide a sensible default population for manual testing.
|
retest this please |
1 similar comment
|
retest this please |
|
Closing become #4295 includes it , and it was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Now AWS Aurora makes use of
hostgroup_attributesfor being able to specify the following attributes for autodiscovered servers:max_connectionsuse_sslThe server option
weighthonors the configurationnew_reader_weightfrommysql_aws_aurora_hostgroupsinstead of the particular hostgroup attribute.Fixes
On top of the described feature, this PR fixes several issues found with Aurora monitoring:
The following issue found with checksums computations:
Some of the previously described issues that also affected 'read_only' checks.
IMPORTANT: This PR is built on top of PR #4232, which should me merged first.