Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtest 1.14 vs2022 #8

Merged
merged 12 commits into from
Feb 21, 2024
Merged

Gtest 1.14 vs2022 #8

merged 12 commits into from
Feb 21, 2024

Conversation

Blackvals
Copy link
Collaborator

Moved to VS2022 and GTest 1.14

* Moved JSONAdapterTestUtilities to requirements as private (was misplaced as a build requirement)
* Updated gtest to be version 1.14 (revision 4372c5aed2b4018ed9f9da3e218d18b3)
* Remove options for dependencies as default matches and we are overriding the gtest
* Remove non-Windows files from imports and package.
* Added a conan profile to wrap main settings considering vs2022
* Moved from sh to bat
* Changed build steps to go full conan (which in turn uses cmake)
* Simplified by doing some kind of matrix between architectures (x86, x86_64) and configs (Debug, Release), all expressed in conan terms
* Removed unnecessary files
Propagated changes from Build pipeline to Release pipeline.
conanfile.py Show resolved Hide resolved
Copy link

@Tanaka12 Tanaka12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with changes

Copy link
Contributor

@Thymir Thymir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up

@Blackvals Blackvals closed this Feb 21, 2024
@Blackvals Blackvals reopened this Feb 21, 2024
@Blackvals Blackvals merged commit 565f14b into master Feb 21, 2024
1 of 3 checks passed
@Blackvals Blackvals deleted the gtest-1.14_vs2022 branch February 21, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants