-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gtest 1.14 vs2022 #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved JSONAdapterTestUtilities to requirements as private (was misplaced as a build requirement) * Updated gtest to be version 1.14 (revision 4372c5aed2b4018ed9f9da3e218d18b3) * Remove options for dependencies as default matches and we are overriding the gtest * Remove non-Windows files from imports and package.
* Added a conan profile to wrap main settings considering vs2022 * Moved from sh to bat * Changed build steps to go full conan (which in turn uses cmake) * Simplified by doing some kind of matrix between architectures (x86, x86_64) and configs (Debug, Release), all expressed in conan terms * Removed unnecessary files
Propagated changes from Build pipeline to Release pipeline.
Tanaka12
reviewed
Feb 21, 2024
Tanaka12
reviewed
Feb 21, 2024
Tanaka12
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with changes
Thymir
reviewed
Feb 21, 2024
Thymir
reviewed
Feb 21, 2024
Thymir
approved these changes
Feb 21, 2024
Thymir
reviewed
Feb 21, 2024
Thymir
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to VS2022 and GTest 1.14