Update pop-keyboard-shortcuts.md #1236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobgkau
requested changes
Jul 31, 2024
| | <kbd>SUPER</kbd> + <kbd>ESC</kbd> | Lock the screen | | ||
|
|
||
| ### Use the launcher | ||
|
|
||
| The launcher allows searching through open windows and installed applications, and also has the additional functions listed below. | ||
| The launcher allows searching through open windows and installed applications and has the additional functions listed below. |
There was a problem hiding this comment.
While I appreciate the drive for conciseness, this change makes the "and"s run together and makes the sentence less clear. I think the old wording for this line was better.
If you want to make it more grammatically correct than it was originally, just add "it" after the "and" (following the comma) since this is an independent clause and should have a subject. (So it should read "and it also has..." after the comma.) Or simply separate it out into two sentences to get rid of the second "and" here.
There was a problem hiding this comment.
I'll fix it myself since it's been a while and the PR author doesn't seem to be around at the moment.
add the key strokes for moving active windows between upper and lower displays
jacobgkau
force-pushed
the
update-keyboard-shortcuts.md
branch
from
17c4bfe
to
e4d0616
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the key strokes for moving active windows between upper and lower displays