Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oryp10 #148

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Add oryp10 #148

merged 5 commits into from
Sep 28, 2022

Conversation

jacobgkau
Copy link
Member

This adds the Oryx Pro 10 to tech docs.

The repair and internal overview photos have been reshot with an oryp10 unit. The external overview page keeps the oryp9 port diagrams (marketing did not reshoot port photos because the chassis did not change); while repair and internal overview photos have switched from 17" to 15", port diagrams stay at the 17" model because marketing did not shoot closed left/right photos of the 15" oryp9.

The main spec updates are the switch from DDR4 3200MHz RAM to DDR5 4800MHz RAM and the addition of a 15" OLED display option. The repairs page reflects that heat-conductive metal is only used to cool the GPU (the entire CPU uses regular thermal paste.)

I tried to add verbiage to the repairs page warning about the difficulty and risk of removing the keyboard. I currently do not have anything about using rubbing alcohol to dissolve the adhesive (that seems like a risky thing to recommend.)

@jacobgkau jacobgkau requested review from a team September 27, 2022 22:09
leviport
leviport previously approved these changes Sep 27, 2022
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think this is ready to merge as soon as the product launches.

@jacobgkau
Copy link
Member Author

Looks like the CI build is failing for some reason:

   Compiling mdbook v0.4.18
error[E0597]: `local_ctx` does not live long enough
   --> /usr/local/cargo/registry/src/git.luolix.top-1ecc6299db9ec823/mdbook-0.4.18/src/renderer/html_handlebars/helpers/navigation.rs:154:25
    |
154 |             t.render(r, &local_ctx, &mut local_rc, out)
    |                         ^^^^^^^^^^ borrowed value does not live long enough
155 |         })?;
    |         -
    |         |
    |         `local_ctx` dropped here while still borrowed
    |         borrow might be used here, when `local_rc` is dropped and runs the destructor for type `handlebars::RenderContext<'_, '_>`
    |
    = note: values in a scope are dropped in the opposite order they are defined

For more information about this error, try `rustc --explain E0597`.
error: could not compile `mdbook` due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `mdbook v0.4.18`, intermediate artifacts can be found at `/tmp/cargo-install8itaP8`
Error: Process completed with exit code 101.

@jacobgkau
Copy link
Member Author

Looks like this was worked around in mdbook: rust-lang/mdBook#1860

Although it sounds like it was caused by a Rust update: rust-lang/rust#99591

Not sure why this is becoming a problem for us right now, but I'll try updating mdbook to the latest version.

@leviport leviport merged commit 73ea40a into master Sep 28, 2022
@leviport leviport deleted the oryp10 branch September 28, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants