Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop two unneeded calls to umask() #3468

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Drop two unneeded calls to umask() #3468

merged 1 commit into from
Feb 4, 2025

Conversation

DaanDeMeyer
Copy link
Contributor

Both these commands write temporary files to the workspace which are not written to the image, so no need to care about the umask.

@DaanDeMeyer
Drop two unneeded calls to umask()
8577dfc 
Both these commands write temporary files to the workspace which
are not written to the image, so no need to care about the umask.
behrmann
behrmann approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. None of the the commands warns about permissions, right?

@DaanDeMeyer
Copy link
Contributor Author

Looks reasonable. None of the the commands warns about permissions, right?

They're operating on certificates, which are public, so no

@DaanDeMeyer DaanDeMeyer merged commit d70b67a into systemd:main Feb 4, 2025
31 of 35 checks passed
@DaanDeMeyer DaanDeMeyer deleted the umask branch February 4, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behrmann behrmann behrmann approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaanDeMeyer @behrmann