Rust 2018 + failure → anyhow + misc fixes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keszybz
reviewed
Jun 5, 2020
| @@ -202,6 +202,7 @@ After={service} | |||
|
|
|||
| [Swap] | |||
| What={root}dev/{zram_device} | |||
| Options=pri=100 | |||
There was a problem hiding this comment.
Please use Priority=100 instead.
There was a problem hiding this comment.
I now see #12 (comment). So maybe let's leave this with Options= for now, and figure out why Priority does now work later.
There was a problem hiding this comment.
I'll test this on my laptop today and check what's the problem.
ignatenkobrain
force-pushed
the
upd
branch
2 times, most recently
from
6b6352b
to
6e1b55b
Compare
Examples: nabijaczleweli@nabtop:~/code/zram-generator$ find test.root/ -type f test.root/etc/systemd/zram-generator.conf test.root/proc/meminfo nabijaczleweli@nabtop:~/code/zram-generator$ ZRAM_GENERATOR_ROOT=test.root ./target/debug/zram-generator test.out Using "test.root/" as root directory Found configuration for zram0: memory-limit=9048MB zram-fraction=0.1 Creating swap-create@zram0.service for test.root/dev/zram0 (380MB) nabijaczleweli@nabtop:~/code/zram-generator$ find test.root/ -type f test.root/etc/systemd/zram-generator.conf test.root/proc/meminfo test.root/run/modules-load.d/zram.conf nabijaczleweli@nabtop:~/code/zram-generator$ find test.out/ \( -type f -o -type l \) test.out/swap-create@zram0.service test.out/swap.target.wants/dev-zram0.swap test.out/dev-zram0.swap
This is the default for zram swaps in the Debian zram-tools package Ref: systemd#8
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
As well as to the Rust 2018. Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
I am not sure if return codes are used for anything though. Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #12