Skip to content

Commit

Permalink
Merge pull request #5145 from systeminit/wendy/templating-ui-tweaks
Browse files Browse the repository at this point in the history
toasts and other UI adjustments for template generation
  • Loading branch information
wendybujalski authored Dec 17, 2024
2 parents 68eca14 + c1c35bc commit ab45c1d
Show file tree
Hide file tree
Showing 7 changed files with 255 additions and 145 deletions.
2 changes: 1 addition & 1 deletion app/web/src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const { theme: rootTheme } = useThemeContainer();
const windowWidth = ref(window.innerWidth);
const windowSizeClasses = computed(() =>
windowWidth.value < APP_MINIMUM_WIDTH
? `min-w-[${APP_MINIMUM_WIDTH}px] overflow-x-auto`
? tw`min-w-[650px] overflow-x-auto` // APP_MINIMUM_WIDTH
: "",
);

Expand Down
16 changes: 16 additions & 0 deletions app/web/src/components/AttributesPanel/AttributesPanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,22 @@
<LoadingMessage v-if="loadSchemaReqStatus.isPending && !domainTree">
Loading asset schema
</LoadingMessage>
<div
v-else-if="
domainTree &&
domainTree.children.length === 0 &&
secretsTree &&
secretsTree.children.length === 0
"
:class="
clsx(
'text-center px-xs py-sm italic',
themeClasses('text-neutral-700', 'text-neutral-300'),
)
"
>
No attributes to display.
</div>
<div
v-else-if="domainTree"
:class="
Expand Down
3 changes: 3 additions & 0 deletions app/web/src/components/ManagementRunPrototype.vue
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ const runPrototype = async (viewId: ViewId) => {
);
if (result.result.success) {
// TODO(WENDY) - for template functions, select the returned componentIds
// modelingEventBus.emit("setSelection", componentIds);
lastExecution.value = result.result.data;
if (result.result.data.message) {
const toastOptions = {
Expand Down
Loading

0 comments on commit ab45c1d

Please sign in to comment.