fix(dal): export default values correctly #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
👎 Rejected by PR status |
zacharyhamm
force-pushed
the
zack/fix-default-values-on-export
branch
from
230d379 to
2920caa
Compare
A bit of code left over from the old system (where default values were the attribute value for a prop at the schema variant context) was grabbing the first attribute value and making it the default for props if a component existed on export. This fixes it and fixes the export of default values for strings. Default values now can only be defined in the asset spec. Co-Authored-By: Paul Stack <paul@systeminit.com>
zacharyhamm
force-pushed
the
zack/fix-default-values-on-export
branch
from
2920caa to
b20aa9d
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of code left over from the old system (where default values were the attribute value for a prop at the schema variant context) was grabbing the first attribute value and making it the default for props if a component existed on export. This fixes it and fixes the export of default values for strings.
Default values now can only be defined in the asset spec.