New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdf): return 404 if the func is not found in the requested changeset #4155

Merged

britmyerss merged 1 commit into main from brit/bug-458-return-404-from-func-v2-routes

Jul 15, 2024

Contributor

britmyerss commented Jul 15, 2024

via Quickpage on GIPHY


          fix(sdf): return 404 if the func is not found in the requested changeset

fa7a4aa

britmyerss requested a review from nickgerace

July 15, 2024 20:56

github-actions bot added the A-sdf label

stack72 reviewed

View reviewed changes

lib/sdf-server/src/server/service/v2/func.rs

-                  let func = Func::get_by_id_or_error(ctx, func_id).await?;
+                  let func = Func::get_by_id(ctx, func_id)
+                      .await?
+                      .ok_or(FuncAPIError::FuncNotFound(func_id))?;

Contributor

stack72 Jul 15, 2024

NICE!!!

nickgerace approved these changes

View reviewed changes

Contributor

nickgerace left a comment

britmyerss added this pull request to the merge queue

Merged via the queue into main with commit e4e82d2

8 checks passed

britmyerss deleted the brit/bug-458-return-404-from-func-v2-routes branch

July 15, 2024 21:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-sdf