Victor/eng 2696 migrate current diagram to view #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-sdf
vbustamante
commented
Oct 23, 2024
Comment on lines
+88
to
+92
| info!("Migrating {} snapshot(s)", open_change_sets.len(),); | ||
|
|
||
| loop { | ||
| let change_sets_to_migrate = change_set_graph.independent_ids(); | ||
| if change_sets_to_migrate.is_empty() { | ||
| break; | ||
| for change_set in open_change_sets { | ||
| let mut change_set = ChangeSet::find(ctx, change_set.id) | ||
| .await? | ||
| .ok_or(ChangeSetError::ChangeSetNotFound(change_set.id))?; |
There was a problem hiding this comment.
This should prevent any infinite loops
This reverts commit e871d7f.
vbustamante
force-pushed
the
victor/eng-2696-migrate-current-diagram-to-view
branch
2 times, most recently
from
bee6c1d to
0e7af73
Compare
|
/try |
vbustamante
force-pushed
the
victor/eng-2696-migrate-current-diagram-to-view
branch
from
0e7af73 to
68caa95
Compare
|
/try |
zacharyhamm
approved these changes
Oct 23, 2024
vbustamante
deleted the
victor/eng-2696-migrate-current-diagram-to-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try this again without a possible loop in the changeset listing