Fix: Restore geometries too #5108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vbustamante
commented
Dec 11, 2024
vbustamante
commented
Signed-off-by: Victor Bustamante <victor@systeminit.com>
|
Looks good to me - but we should either add a new test or expand an existing one to cover this going forward. |
jobelenus
approved these changes
Dec 11, 2024
britmyerss
reviewed
Dec 11, 2024
| @@ -3332,6 +3332,10 @@ impl Component { | |||
| ctx.add_dependent_values_and_enqueue(component.input_socket_attribute_values(ctx).await?) | |||
| .await?; | |||
|
|
|||
| Geometry::restore_all_for_component_id(ctx, component_id) | |||
There was a problem hiding this comment.
The reason you went here vs. expanding the import_component_subgraph is because the geometries aren't in the subgraph of the component?
There was a problem hiding this comment.
@britmyerss yeah, the subgraph code is very generic. Since we've structured our geometries the other way around I had to implement a special case here
britmyerss
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.