Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching workspaces and change sets, minimum app width, and more! #5109

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Searching workspaces and change sets, minimum app width, and more! #5109

merged 1 commit into from
Dec 11, 2024

Conversation

wendybujalski
Copy link
Contributor

  • Created DropdownMenuButton component for using DropdownMenu to replace VormInput dropdowns
  • Workspaces and Change Sets dropdowns on the Navbar now use DropdownMenuButton and have search enabled when there are more than 20 Workspaces or Change Sets
  • Replaced a few other instances of VormInput dropdowns with DropdownMenuButton
  • Fixed minor style bug on WorkspaceDetailsPage
  • Minimum browser window width of 650 pixels is now enforced cleanly on the application
  • Navbar elegantly collapses down to the minimum width of 650 pixels instead of breaking on narrower widths
  • Fixed bugs in the Collaborators component, added a function for testing it
  • Fixed ModelingDiagram misalignment bug caused by LeftPanelDrawer changes
  • Fixed SiSearch styles to look better inside of DropdownMenu
  • A few other minor bug fixes and UI improvements as well

@github-actions github-actions bot added the A-web label Dec 11, 2024
@wendybujalski
Copy link
Contributor Author

Screenshot 2024-12-11 at 5 56 16 PM

jobelenus
jobelenus previously approved these changes Dec 11, 2024
View reviewed changes
@wendybujalski wendybujalski force-pushed the wendy/more-dropdown-menu-stuff branch from 2316441 to 60cee48 Compare December 11, 2024 23:02
@wendybujalski wendybujalski added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit aac09f3 Dec 11, 2024
8 checks passed
@wendybujalski wendybujalski deleted the wendy/more-dropdown-menu-stuff branch December 11, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobelenus jobelenus jobelenus approved these changes

@britmyerss britmyerss Awaiting requested review from britmyerss

@stack72 stack72 Awaiting requested review from stack72

Assignees
No one assigned
Labels
A-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendybujalski @jobelenus