Template management func generation UI #5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobelenus
reviewed
Dec 13, 2024
| @@ -416,6 +416,18 @@ const rightClickMenuItems = computed(() => { | |||
| disabled, | |||
| }); | |||
| } | |||
| if ( | |||
| restorableSelectedComponents.value.length === 0 && | |||
| featureFlagsStore.TEMPLATE_MGMT_FUNC_GENERATION | |||
There was a problem hiding this comment.
Does this also ensure that no view hexagons are selected?
There was a problem hiding this comment.
Yes! The code on line 298 prevents any of the stuff below that line from having view hexagons selected.
jobelenus
previously approved these changes
Dec 13, 2024
zacharyhamm
previously approved these changes
Dec 13, 2024
| @@ -18,6 +18,7 @@ const FLAG_MAPPING = { | |||
| REBAC: "rebac", | |||
| OUTLINER_VIEWS: "diagram-outline-show-views", | |||
| SLACK_WEBHOOK: "slack_webhook", | |||
| TEMPLATE_MGMT_FUNC_GENERATION: "template-mgmt-func-generation", | |||
wendybujalski
dismissed stale reviews from zacharyhamm and jobelenus
via
6cbcebe
wendybujalski
force-pushed
the
wendy/eng-2878-extract-to-mgmt-func-modal
branch
from
6cbcebe to
36cb613
Compare
zacharyhamm
previously approved these changes
Dec 13, 2024
wendybujalski
force-pushed
the
wendy/eng-2878-extract-to-mgmt-func-modal
branch
from
9365e87 to
77346c3
Compare
stack72
approved these changes
Dec 13, 2024
zacharyhamm
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-12-13.at.5.01.41.PM.mov
also some
VormInputfixes, a fix on the diagam, some newModelingDiagramdebug info, and a little refactoring