Fix: load all components at the right time #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobelenus
force-pushed
the
fix/all-components-call-in-a-good-place
branch
from
0dd1172 to
7326e60
Compare
|
Taking a look! But note the failed lints |
After first paint, but before the data is required by other things!
jobelenus
force-pushed
the
fix/all-components-call-in-a-good-place
branch
from
7326e60 to
b6aeeb7
Compare
zacharyhamm
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After first paint, but before the data is required by other things! And don't do it twice!
Tested this against all the regressions we've been bashing away on (e.g. no blank modeling screen, no missing component on apply)
