Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: dont make parents smaller, also fixed the bug why we thought new children didnt fit inside the parent #5175

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix: dont make parents smaller, also fixed the bug why we thought new children didnt fit inside the parent #5175

merged 1 commit into from
Dec 20, 2024

Conversation

jobelenus
Copy link
Contributor

@github-actions github-actions bot added the A-web label Dec 20, 2024
fnichol
fnichol approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@fnichol fnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I don't believe I'm seeing the bug behavior anymore with this change.

@fnichol fnichol added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 6910be4 Dec 20, 2024
8 checks passed
@fnichol fnichol deleted the fix/dont-make-frames-smaller branch December 20, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnichol fnichol fnichol approved these changes

@wendybujalski wendybujalski Awaiting requested review from wendybujalski

@zacharyhamm zacharyhamm Awaiting requested review from zacharyhamm

Assignees
No one assigned
Labels
A-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jobelenus @fnichol