Fix: apply move to head from a view that doesnt exist there #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyhamm
reviewed
Dec 20, 2024
| @@ -603,6 +604,21 @@ export function useChangeSetsStore() { | |||
| const route = useRouterStore().currentRoute; | |||
|
|
|||
| if (route?.name) { | |||
| // am i on a view, and about to move to head | |||
| // where that view does not yet exist | |||
| if ("viewId" in route.params) { | |||
There was a problem hiding this comment.
Should this be generic, for switching between any change set? Or does it only matter when going to head
There was a problem hiding this comment.
this spot is only about moving to head after apply... i will add the changeset dropdown
jobelenus
deleted the
fix/apply-move-to-head-with-view-that-doesnt-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.