fix D1 driver implementation using stmt.raw({ columnNames: true }) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syumai
reviewed
Apr 24, 2024
cloudflare/d1/stmt.go
Outdated
| @@ -59,15 +59,30 @@ func (s *stmt) QueryContext(_ context.Context, args []driver.NamedValue) (driver | |||
| for i, arg := range args { | |||
| argValues[i] = arg.Value | |||
| } | |||
| resultPromise := s.stmtObj.Call("bind", argValues...).Call("all") | |||
| resultPromise := s.stmtObj.Call("bind", argValues...).Call("raw", map[string]interface{}{"columnNames": true}) | |||
There was a problem hiding this comment.
nits
Suggested change
| resultPromise := s.stmtObj.Call("bind", argValues...).Call("raw", map[string]interface{}{"columnNames": true}) | |
| resultPromise := s.stmtObj.Call("bind", argValues...).Call("raw", map[string]any{"columnNames": true}) |
syumai
reviewed
Apr 24, 2024
cloudflare/d1/stmt.go
Outdated
| columns: nil, | ||
| rowsObj: rowsObj, | ||
| }, nil | ||
| } else { |
There was a problem hiding this comment.
nits: Since the if block returns early, there is no need for a corresponding else block. I want to keep the block nesting shallow.
|
@zztkm Thanks! I posted some trivial comments, please check them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
close: #106
Motivation